Skip symbol insertion for unreachable basic blocks #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fennecJ
force-pushed
the
skip_symbol_insertion_in_unreachable_BB
branch
from
ab6460f to
7cd3787
Compare
Previously, the compiler would throw a segmentation fault if the
compiled code contained a declaration after a return statement.
For example:
int main() {
return 0;
int a = 5;
}
This occurred when the basic block (bb) for unreachable code was null,
while the function add_symbol(basic_block_t *bb, var_t *var) did not
check for null before attempting to insert a variable, leading to a
segmentation fault.
This commit fixes the issue by skipping symbol insertion if the basic
block is unreachable (null).
fennecJ
force-pushed
the
skip_symbol_insertion_in_unreachable_BB
branch
from
7cd3787 to
1a11b2a
Compare
|
Thank @fennecJ for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the compiler would throw a segmentation fault if the compiled code contained a declaration after a return statement. For example:
int main() {
return 0;
int a = 5;
}
This occurred when the basic block (bb) for unreachable code was null, while the function add_symbol(basic_block_t *bb, var_t *var) did not check for null before attempting to insert a variable, leading to a segmentation fault.
This commit fixes the issue by skipping symbol insertion if the basic block is unreachable (null).